Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Enhancement] Shapes attributes #32

Merged
merged 7 commits into from
Jan 10, 2025
Merged

[Enhancement] Shapes attributes #32

merged 7 commits into from
Jan 10, 2025

Conversation

lucas-diedrich
Copy link
Collaborator

This addresses the feature request in issue #22

  • Adds capability to read in the CapID attribute from a .xml shapes node.
  • Adds regex-based parsing of coordinate names to make expectations in the coordinate format more explicit.
  • Added tests for method with example XML file

@lucas-diedrich lucas-diedrich mentioned this pull request Jan 9, 2025
Closed
sophiamaedler
sophiamaedler approved these changes Jan 10, 2025
View reviewed changes
Copy link
Collaborator

@sophiamaedler sophiamaedler left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@sophiamaedler sophiamaedler merged commit 8293d49 into main Jan 10, 2025
2 checks passed
@sophiamaedler sophiamaedler deleted the shape-attributes branch January 10, 2025 15:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@sophiamaedler sophiamaedler sophiamaedler approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@lucas-diedrich @sophiamaedler